Re: [PATCH] dma-mapping: Remove WARN_ON in dma_free_coherent

From: Matthew Wilcox
Date: Mon Mar 29 2010 - 16:41:32 EST


On Mon, Mar 29, 2010 at 08:09:21PM +0200, Stefan Bader wrote:
> But it seems modifying that driver would be a bigger effort and maybe
> not really worthwile as it is a rather old driver. On the other side
> I was told [1] that this WARN_ON applies only to ARM which could sleep
> in the free path and it is just bogus for X86. As the code is in
> arch/x86 it would never be used for anything else than X86 and if
> its truely bogus on X86, couldn't it get removed?

My suggestion was that you remove it from the Ubuntu kernel, not submit
it upstream.

--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/