Re: [PATCH 07/11] Memory compaction core

From: Jonathan Corbet
Date: Wed Mar 24 2010 - 16:59:53 EST


On Wed, 24 Mar 2010 13:33:47 -0700
Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> > + VM_BUG_ON(cc == NULL);
>
> It's a bit strange to test this when we're about to oops anyway. The
> oops will tell us the same thing.

...except that we've seen a fair number of null pointer dereference
exploits that have told us something altogether different. Are we
*sure* we don't want to test for null pointers...?

jon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/