Re: [PATCH] staging: winbond: wb35reg_f.h Coding style fixes.
From: Pekka Enberg
Date: Mon Mar 22 2010 - 03:16:25 EST
Lars Lindley kirjoitti:
I fixed the checkpatch things except a couple of long lines.
I also removed hungarian notation from the argument names
and some "commented away" code.
Signed-off-by: Lars Lindley <lindley@xxxxxxxxxx>
Did you check that all these function declarations are actually used?
I've spotted plenty of dead code in the past.
+/*
+ * ====================================
+ * Interface function declare
+ * ====================================
+ */
+unsigned char Wb35Reg_initial(struct hw_data *HwData);
Lets avoid CamelCase for the arguments so "hw_data" here, for example. I
see the same thing elsewhere in this patch as well.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/