Re: [RFC PATCH 1/5] use nr_cpus= to set nr_cpu_ids early

From: Yinghai Lu
Date: Tue Jan 12 2010 - 17:23:42 EST

On Tue, Jan 12, 2010 at 12:48 PM, Christoph Lameter
<cl@xxxxxxxxxxxxxxxxxxxx> wrote:
> Trouble is that NR_CPUS is used all over the place. If nr_cpu_ids <
> NR_CPUS at boot then there is a danger of for loops to NR_CPUS going out
> of
> bounds.
> CONFIG_NR_CPUS is used for various bitmaps so that seems to be
> okay.


> drivers/acpi/numa.c:acpi_numa_init probably should use nr_cpu_ids
> instead now.

before prefill_possible_map for x86
before setup_nr_cpu_ids for other platform

nr_cpu_ids = NR_CPUS = CONFIG_NR_CPUS

> There is an octeon driver in staging that has some issues with NR_CPUS as
> well.

that should be fixed, we should use nr_cpu_ids instead for them.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at