Re: [PATCH 4/4] uml: line.c: avoid NULL pointer dereference

From: Alexander Beregalov
Date: Thu Jan 07 2010 - 10:56:58 EST


2010/1/7 Jeff Dike <jdike@xxxxxxxxxxx>:
> On Thu, Jan 07, 2010 at 04:48:41AM +0300, Alexander Beregalov wrote:
>> Assign tty only if line is not NULL.
>
>> Â Â Â if (line)
>> + Â Â Â Â Â Â tty = line->tty;
>> Â Â Â Â Â Â Â chan_interrupt(&line->chan_list, &line->task, tty, irq);
>> Â Â Â return IRQ_HANDLED;
>
> Even if the thinking is correct, aren't you missing some braces?

Oops, sorry, I will send another version.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/