Re: [PATCH 4/4] uml: line.c: avoid NULL pointer dereference

[Jeff Dike]

On Thu, Jan 07, 2010 at 04:48:41AM +0300, Alexander Beregalov wrote:
> Assign tty only if line is not NULL.

>  	if (line)
> +		tty = line->tty;
>  		chan_interrupt(&line->chan_list, &line->task, tty, irq);
>  	return IRQ_HANDLED;

Even if the thinking is correct, aren't you missing some braces?

				Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/