Re: [Kgdb-bugreport] [PATCH 09/37] kgdb,blackfin: Add in kgdb_arch_set_pc for blackfin

[Mike Frysinger]

On Wed, Jan 6, 2010 at 15:34, Jason Wessel wrote:
> Mike Frysinger wrote:
>> also, i see you added "notrace" to the Blackfin probe_kernel_write ...
>> was that intentional ? Âif so, this should probably go into
>> include/linux/uaccess.h instead
>
> The notrace was just a cut and paste of the original in mm/maccess.c

ah, i thought i checked mm/maccess.c, but i guess i looked at just
probe_kernel_read().  the fact that this was missed under the Blackfin
code is a good example for why notrace should be on prototypes, not
function definitions :).  i'll send a sep patch for just this.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/