Re: [PATCH 4/7] can/at91: don't check platform_get_irq's return valueagainst zero

From: Wolfgang Grandegger
Date: Thu Dec 17 2009 - 02:18:40 EST

Alan Cox wrote:
>> + if (!res || irq <= (int)NO_IRQ) {
>> but this looks too ugly. (IMHO using NO_IRQ is already ugly.)
> No IRQ was a private variable for the drivers/ide stack internally and
> only present in any form on a few odd platforms where it got "borrowed"
> and hasn't yet been eliminated
> The absence of an IRQ is zero. A bus IRQ of zero is remapped by the OS.

OK, I was remembering some old issues with NO_IRQ. Next time I will read
the commit message more carefully. Sorry for the noise.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at