Re: [PATCH 4/7] can/at91: don't check platform_get_irq's returnvalue against zero

From: Alan Cox
Date: Wed Dec 16 2009 - 12:48:41 EST

> + if (!res || irq <= (int)NO_IRQ) {
> but this looks too ugly. (IMHO using NO_IRQ is already ugly.)

No IRQ was a private variable for the drivers/ide stack internally and
only present in any form on a few odd platforms where it got "borrowed"
and hasn't yet been eliminated

The absence of an IRQ is zero. A bus IRQ of zero is remapped by the OS.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at