Re: [PATCH 1/3] perf: Fix timechart header handling

From: Ingo Molnar
Date: Sun Dec 06 2009 - 06:55:16 EST



* OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx> wrote:

> Hi,
>
> Update "struct trace_entry" to match with current one. And remove
> "size" field from it.
>
> If it has "size", it become cause of alignment mismatch of structure
> with kernel.
>
> Signed-off-by: OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
> ---
>
> tools/perf/builtin-timechart.c | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)

Just curious, have you tested timechart functionality after having done
this change - does it still work fine for you?

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/