Re: [PATCH 00/86] PATA fixes

From: Jeff Garzik
Date: Thu Dec 03 2009 - 17:31:00 EST


On 12/03/2009 05:23 PM, Bartlomiej Zolnierkiewicz wrote:
On Thursday 03 December 2009 11:10:51 pm Jeff Garzik wrote:
Is it good kernel practice to intermingle cosmetic changes with
functional ones, in the same code lines? Also, no.

I prefer using common sense over black-and-white rules.

If patch is a _really_ tiny one (< 20 LOC changed) it sometimes makes
sense to save the time on handling separate patches.

This is open source -- you have to consider the time saved by reviewers too.

But I doubt you have saved time on all your motivated commit searches, so...

Jeff



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/