Re: [PATCH -queue v0 1/6] [loongson] add basic loongson-2f support
From: Arnaud Patard
Date: Wed Nov 04 2009 - 06:36:18 EST
Wu Zhangjin <wuzhangjin@xxxxxxxxx> writes:
> On Wed, 2009-11-04 at 11:28 +0100, Arnaud Patard wrote:
>> > +
>> > +config CPU_LOONGSON2F
>> > + bool "Loongson 2F"
>> > + depends on SYS_HAS_CPU_LOONGSON2F
>> > + select CPU_LOONGSON2
>> > + help
>> > + The Loongson 2F processor implements the MIPS III instruction set
>> > + with many extensions.
>> > +
>> > + Loongson2F have built-in DDR2 and PCIX controller. The PCIX controller
>> > + have a similar programming interface with FPGA northbridge used in
>> > + Loongson2E.
>> > +
>> Small question : Why don't you restrict to 64bit kernels only ? From
>> what I remember from some discussions with ST, trying to use a 32-bit
>> kernel on 2f is a nice way to get troubles. It would be better imho to
>> forbid such a configuration. As a side effect, this will remove all
>> 'defined(CONFIG_64BIT)' parts of your #ifdef tests.
> It's hard to make such a decision ;) Perhaps some guys want to play with
> the 32bit version.
It's a matter of taste : using 32 bit and getting an more or less broken
machine or using 64bit and getting a working machine. I don't think a
lot of people will choose the first option :)
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/