Re: Please consider reverting7d930bc33653d5592dc386a76a38f39c2e962344

From: Linus Torvalds
Date: Tue Nov 03 2009 - 10:45:21 EST




On Wed, 4 Nov 2009, Marcel Holtmann wrote:
>
> no questions that it needs fixed, I agree with you. However just blindly
> reverting something, because it fixes it for one or two people, might
> have side effects that causes more problems than the revert would
> actually fix.

Stop whining. Really.

Everybody understands that it should be fixed. That's not the question.

But it should be fixed _quickly_. In this case, I have a bisection report
FROM TWO DAYS AGO. And I'm still kicking myself for not just reverting
that piece-of-shit commit then, because I spent the time to look at the
oops and the commit, and could tell that it was crap.

Instead, I _did_ wait for the subsystem maintainer to get around to it. As
a result of waiting, I've now wasted time for a lot of other people.

So stop your claptrap. You're wrong. I would suggest you now thank Dmitry,
and ask his forgiveness for (a) wasting his time and (b) then berating him
for it.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/