Re: [PATCH 1/1] tty: Mark generic_serial users as BROKEN

[Geert Uytterhoeven]

On Fri, Oct 30, 2009 at 23:13, Greg Kroah-Hartman <gregkh@xxxxxxx> wrote:
> From: Alan Cox <alan@xxxxxxxxxxxxxxx>
>
> There isn't much else I can do with these. I can find no hardware for any
> of them and no users. The code is broken.

Can you please also mention in the changelog what exactly is broken?

BTW, in response to your patch I received (private) email from people
who actually
have m68k MVME boards in active use. So marking it broken may be
called a regression...

Thanks!

> Signed-off-by: Alan Cox <alan@xxxxxxxxxxxxxxx>
> Cc: stable <stable@xxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
> ---
> Âarch/m68k/Kconfig  Â|  Â6 +++---
> Âdrivers/char/Kconfig | Â Â6 +++---
> Â2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/m68k/Kconfig b/arch/m68k/Kconfig
> index 29dd848..ecdc19a 100644
> --- a/arch/m68k/Kconfig
> +++ b/arch/m68k/Kconfig
> @@ -561,7 +561,7 @@ config HPAPCI
>
> Âconfig MVME147_SCC
> Â Â Â Âbool "SCC support for MVME147 serial ports"
> - Â Â Â depends on MVME147
> + Â Â Â depends on MVME147 && BROKEN
> Â Â Â Âhelp
> Â Â Â Â ÂThis is the driver for the serial ports on the Motorola MVME147
> Â Â Â Â Âboards. ÂEveryone using one of these boards should say Y here.
> @@ -576,14 +576,14 @@ config SERIAL167
>
> Âconfig MVME162_SCC
> Â Â Â Âbool "SCC support for MVME162 serial ports"
> - Â Â Â depends on MVME16x
> + Â Â Â depends on MVME16x && BROKEN
> Â Â Â Âhelp
> Â Â Â Â ÂThis is the driver for the serial ports on the Motorola MVME162 and
> Â Â Â Â Â172 boards. ÂEveryone using one of these boards should say Y here.
>
> Âconfig BVME6000_SCC
> Â Â Â Âbool "SCC support for BVME6000 serial ports"
> - Â Â Â depends on BVME6000
> + Â Â Â depends on BVME6000 && BROKEN
> Â Â Â Âhelp
> Â Â Â Â ÂThis is the driver for the serial ports on the BVME4000 and BVME6000
> Â Â Â Â Âboards from BVM Ltd. ÂEveryone using one of these boards should say
> diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
> index 08a6f50..6aad99e 100644
> --- a/drivers/char/Kconfig
> +++ b/drivers/char/Kconfig
> @@ -323,7 +323,7 @@ config SPECIALIX
>
> Âconfig SX
> Â Â Â Âtristate "Specialix SX (and SI) card support"
> - Â Â Â depends on SERIAL_NONSTANDARD && (PCI || EISA || ISA)
> + Â Â Â depends on SERIAL_NONSTANDARD && (PCI || EISA || ISA) && BROKEN
> Â Â Â Âhelp
> Â Â Â Â ÂThis is a driver for the SX and SI multiport serial cards.
> Â Â Â Â ÂPlease read the file <file:Documentation/serial/sx.txt> for details.
> @@ -334,7 +334,7 @@ config SX
>
> Âconfig RIO
> Â Â Â Âtristate "Specialix RIO system support"
> - Â Â Â depends on SERIAL_NONSTANDARD
> + Â Â Â depends on SERIAL_NONSTANDARD && BROKEN
> Â Â Â Âhelp
> Â Â Â Â ÂThis is a driver for the Specialix RIO, a smart serial card which
> Â Â Â Â Âdrives an outboard box that can support up to 128 ports. ÂProduct
> @@ -395,7 +395,7 @@ config NOZOMI
>
> Âconfig A2232
> Â Â Â Âtristate "Commodore A2232 serial support (EXPERIMENTAL)"
> - Â Â Â depends on EXPERIMENTAL && ZORRO && BROKEN_ON_SMP
> + Â Â Â depends on EXPERIMENTAL && ZORRO && BROKEN
> Â Â Â Â---help---
> Â Â Â Â ÂThis option supports the 2232 7-port serial card shipped with the
> Â Â Â Â ÂAmiga 2000 and other Zorro-bus machines, dating from 1989. ÂAt

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/