Re: pull request: wireless-next-2.6 2009-10-28
From: Ingo Molnar
Date: Mon Nov 02 2009 - 05:11:56 EST
* Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote:
> On Mon, 2009-11-02 at 10:10 +0100, Ingo Molnar wrote:
> > So i have read the thread you and Bartlomiej referenced:
> > http://lkml.org/lkml/2009/10/17/81
> > ... and my understanding of that discussion is very different from
> > yours. Here is my annotated history of the beginnings of that
> > discussion:
> You shouldn't ignore all previous interaction between Bart and us --
> which wasn't pretty: http://thread.gmane.org/gmane.linux.kernel/901892
I have seen that exchange too - here's the lkml.org link for those who
like the lkml.org format:
And i can see no supporting fact here either, for the (very serious)
accusation launched by John Linville, that Bartlomiej is 'petty,
whining, indignant'. In my reading he is the opposite of that, even in
this second thread you point out.
So, no matter how much you disagree about the code and its direction,
please either back up your assertion with specific links to a pattern of
misbehavior or apologize for the ad-hominen attacks against Bartlomiej.
> Of course we were biased when he came around with that petty code
> duplication argument, since it seemed to support only his agenda of
> working only with the staging drivers.
Why do you think that disagreeing in the past gives you the right to get
into ad-hominens? You should concentrate on the code and on the
technical side, not on the person making the argument.
Also, why do you characterise a code duplication argument as 'petty'?
Bloat and unnecessary technical forking is the #1 enemy of Linux.
Integrating code and infrastructure is the #1 strength of Linux.
Upstream subsystems/drivers running away with their private
implementations has its clear costs:
- introduces bugs
- makes drivers shallow in practice
- makes unifying drivers and infrastructure so hard down the road
- bloats the code, increases i$ footprint
I routinely refuse patches based on 'please dont duplicate' arguments,
in fact i did it once today already.
[ I dont know why drivers/staging/ is even an argument here - he argued
about the technical qualities of a new upstream driver, not about a
staging driver. Upstream drivers are to be held to higher standards,
_especially_ now that we can isolate not-clean-enough-yet drivers into
drivers/staging/, without hurting users. ]
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/