Re: [PATCH] x86: adjust GFP mask handling for coherent allocations

From: Jan Beulich
Date: Mon Oct 26 2009 - 11:45:58 EST


>>> Ingo Molnar <mingo@xxxxxxx> 26.10.09 16:22 >>>
>* Jan Beulich <JBeulich@xxxxxxxxxx> wrote:
>> And any attempt to eliminate the conditional another way would just
>> introduce a very similar conditional elsewhere; with this having a
>> single user (and foreseeably not ever a second one) I would think this
>> would just make the code less readable.
>
>There's 3 other current uses of DMA_BIT_MASK(24) in arch/x86 - couldnt
>those use ISA_DMA_BIT_MASK too?

Oh, so you didn't mean me to eliminate the conditional in pci-dma.c, but
just to replace the DMA_BIT_MASK(24) here an elsewhere. Sure, I'm fine
with adding this to the patch.

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/