Re: [RFC V2 PATCH 5/5] cfq-iosched: fairness for sync no-idle queues

[Jeff Moyer]

Corrado Zoccolo <czoccolo@xxxxxxxxx> writes:

> +static enum wl_type_t cfqq_type(struct cfq_queue *cfqq)
> +{
> +	if (!cfq_cfqq_sync(cfqq))
> +		return ASYNC_WORKLOAD;
> +	if (CFQQ_SEEKY(cfqq) || !cfq_cfqq_idle_window(cfqq))
> +		return SYNC_NOIDLE_WORKLOAD;
> +	return SYNC_WORKLOAD;
> +}

The calculation to determine whether or not to idle is now done in at
least 2 places.  Perhaps it's time for a helper function.

There are some other coding style nits, but I'll let Jens comment on
those.  I think the idea looks good.  Once you rebase I'll run some
tests; this is some really good work!

Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/