Re: [PATCH] longhaul: select Longhaul version 2 for capable CPUs

[Dave Jones]

On Sat, Oct 24, 2009 at 05:25:38PM +0200, Krzysztof Helt wrote:
 > From: Krzysztof Helt <krzysztof.h1@xxxxx>
 > 
 > There is a typo in the longhaul detection code so only Longhaul v1 or Longhaul v3
 > is selected. The Longhaul v2 is not selected even for CPUs which are capable of.
 > 
 > Tested on PCChips Giga Pro board. Frequency changes work and the Longhaul v2
 > detects that the board is not capable of changing CPU voltage.
 > 
 > Signed-off-by: Krzysztof Helt <krzysztof.h1@xxxxx>
 
It seems we deliberately changed this two years ago, though the changelog
is a bit sparse on details..

commit 07844252ffd81ec192a62014bada1016c9703765
Author: Rafal Bilski <rafalbilski@xxxxxxxxxx>
Date:   Sun Apr 22 12:26:04 2007 +0200

    [CPUFREQ] Longhaul - Revert Longhaul ver. 2
    
    There is something wrong with this code. It needs more
    testing. It is better to disable it for now because support
    for some machines will be broken.
    
    Signed-off-by: Rafal Bilski <rafalbilski@xxxxxxxxxx>
    Signed-off-by: Dave Jones <davej@xxxxxxxxxx>


In hindsight, changing it to report V1 instead of V2 was the wrong thing
to do, and we should have done something like -ENODEV with
a printk explaining why.

I've not got any old VIA CPUs/boards to test with any more, but I'm inclined
to apply your change, but we'll have to keep an eye out for any strange
bugs on affected systems.  Currently this driver should do nothing, as the
longhaul v1 registers that don't exist on longhaul V2 CPUs. With this change,
we're going to be actually doing scaling again, which may introduce instability
on some machines, as iirc, we never did get this driver 100% stable due
to a lot of really crappy motherboards.

Perhaps we should printk a warning related to this.
(We should definitly mention it in the Kconfig too, which I thought we already had)

	Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/