Re: [PATCH 0/7] kfifo: new API v0.6

From: Andi Kleen
Date: Sat Oct 24 2009 - 21:48:45 EST


On Sat, Oct 24, 2009 at 03:33:14PM +0200, Stefani Seibold wrote:
> This is a new generic kernel FIFO implementation.
>
> The current kernel fifo API is not very widely used, because it has to many
> constrains. Only 17 files in the current 2.6.31-rc5 used it. FIFO's are
> like list's a very basic thing and a kfifo API which handles the most use
> case would save a lot of development time and memory resources.
>
> I think this are the reasons why kfifo is not in use:
>
> - The API is to simple, important functions are missing
> - A fifo can be only allocated dynamically
> - There is a need of a spinlock despite you need it or not
> - There is no support for data records inside a fifo

I have some plans to use this kfifo code in upcoming code (mostly
as a very simple lower overhead NMI safe per CPU fifo). I would appreciate
if it could be merged ASAP

I didn't review this iteration, but earlier ones.

Acked-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/