Re: [PATCH 06/10] x86, mce: make mce_log buffer to per-CPU

From: Hidetoshi Seto
Date: Fri Oct 09 2009 - 01:40:05 EST


Huang Ying wrote:
> I don't think it is a good collaboration style to copy others' patches,
> do some modification and send it out, instead:

Sorry, I could not stop myself since I got frustrated over a trivial matter
around this field in these days. And I could not wait your next post any
more, didn't want to see abandoned "rebased" patch again, so I took this
kind of aggressive violent action in bad manner to push your change.
Sorry again.


> - comment on original patches

I think your patch contains various changes, so how about to break down
this one into small pieces and make patches with proper clearer description.

I believe that the urgent problem can be solved by making the buffer to
per-CPU. Or do you have any reason to rush it into ring buffer?


> - communicate with the original author firstly

Certainly I wrote following line at first:
> Hi Huang,


> - provide another patch on top of original patches

Since what I want to demonstrate to you was another style of your patch,
I could not provide patches in incremental form as usual.


Thanks,
H.Seto

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/