Re: [PATCH 06/10] x86, mce: make mce_log buffer to per-CPU

[Huang Ying]

On Mon, 2009-10-05 at 15:50 +0800, Hidetoshi Seto wrote: 
> Andi Kleen wrote:
> >> (This piece originates from Huang's patch, titled:
> >>  "x86, MCE: Fix bugs and issues of MCE log ring buffer")
> > 
> > You should use proper From: headers then for correct attribution.
> > 
> > -Andi
> 
> I just referred following commit we already have: 
> 
> > commit 77e26cca20013e9352a8df86a54640543304a23a
> > Author: Hidetoshi Seto <seto.hidetoshi@xxxxxxxxxxxxxx>
> > Date:   Thu Jun 11 16:04:35 2009 +0900
> > 
> >     x86, mce: Fix mce printing
> > 
> >     This patch:
> > 
> >      - Adds print_mce_head() instead of first flag
> >      - Makes the header to be printed always
> >      - Stops double printing of corrected errors
> > 
> >     [ This portion originates from Huang Ying's patch ]
> > 
> >     Originally-From: Huang Ying <ying.huang@xxxxxxxxx>
> >     Signed-off-by: Hidetoshi Seto <seto.hidetoshi@xxxxxxxxxxxxxx>
> >     LKML-Reference: <4A30AC83.5010708@xxxxxxxxxxxxxx>
> >     Signed-off-by: Ingo Molnar <mingo@xxxxxxx>
> 
> You mean s/Originally-From/From/, right?
> 
> I'll update attributes if this set need to be revised or if maintainer
> (who expected to be able to set proper attributes) request me to do so.

I don't think it is a good collaboration style to copy others' patches,
do some modification and send it out, instead:

- comment on original patches
- communicate with the original author firstly
- provide another patch on top of original patches

Best Regards,
Huang Ying


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/