Re: ads7846 touchscreen: fix pressure

From: Pavel Machek
Date: Thu Oct 08 2009 - 05:25:37 EST


On Thu 2009-10-08 10:39:39, Trilok Soni wrote:
> Hi Pavel,
>
> On Wed, Oct 7, 2009 at 1:24 AM, Pavel Machek <pavel@xxxxxx> wrote:
> >
> > On Zaurus, pressure is reported inverted -- the lighter the pressure,
> > the bigger numerical value. This should fix it.
> >
> > Signed-off-by: Pavel Machek <pavel@xxxxxx>
> >
> > --- linux-rc/drivers/input.ofic/touchscreen/ads7846.c   2009-10-06 13:49:56.000000000 +0200
> > +++ linux-rc/drivers/input/touchscreen/ads7846.c        2009-10-06 21:18:25.000000000 +0200
> > @@ -608,12 +609,12 @@
> >
> >                input_report_abs(input, ABS_X, x);
> >                input_report_abs(input, ABS_Y, y);
> > -               input_report_abs(input, ABS_PRESSURE, Rt);
> > +               input_report_abs(input, ABS_PRESSURE, ts->pressure_max-Rt);
>
> but same behavior is seen by others using this chip on different
> boards? If not, this has to be done through platform data.

Well, I'd expect the chip to behave in similar way on all
platforms. Of course, it would be good if someone with different hw
tested it, but I do not have that hw...

So I guess the best way is to make it go in early and see how it does
in testing....
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/