Re: [PATCH] use __pa_symbol to calculate the address of a C symbol.

From: Avi Kivity
Date: Mon Aug 31 2009 - 07:24:41 EST

On 08/31/2009 10:04 AM, Glauber Costa wrote:
The use of __pa() to calculate the address of a C-visible symbol
is wrong, and can lead to unpredictable results. See arch/x86/include/asm/page.h
for details.

It should be replaced with __pa_symbol(), that does the correct math here,
by taking relocations into account.

Applied, thanks.

I note that the changelog entry says nothing about what component is involved and what the effect of the bug is. This reduces its usefulness for someone looking over the log and trying to see if a particular bug is fixed.

error compiling committee.c: too many arguments to function

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at