Re: [PATCH] m68k: avoid pgprot_noncached redefinition

From: Heiko Carstens
Date: Thu Aug 27 2009 - 08:38:48 EST

On Thu, Aug 27, 2009 at 02:18:05PM +0200, Geert Uytterhoeven wrote:
> On Thu, Aug 27, 2009 at 13:41, Heiko Carstens<heiko.carstens@xxxxxxxxxx> wrote:
> > From: Heiko Carstens <heiko.carstens@xxxxxxxxxx>
> >
> > While compiling m68k with defconfig I get tons if these warnings:
> >
> > /home2/heicarst/linux-2.6/arch/m68k/include/asm/pgtable_mm.h:148:1: warning: "pgprot_noncached" redefined
> > In file included from /home2/heicarst/linux-2.6/arch/m68k/include/asm/pgtable_mm.h:138,
> >  from /home2/heicarst/linux-2.6/arch/m68k/include/asm/pgtable.h:4,
> >  from include/linux/mm.h:38,
> >  from /home2/heicarst/linux-2.6/arch/m68k/include/asm/atarihw.h:134,
> >  from arch/m68k/atari/debug.c:20:
> > include/asm-generic/pgtable.h:133:1: warning: this is the location of the previous definition
> >
> > Reason for this is that asm-generic/pgtable.h gets included in pgtable_mm.h
> > before pgprot_noncached gets defined.
> > So the check "#ifndef pgprot_noncached" in the generic header file is too early.
> > Solve this by including the generic header file after the arch define.
> Thanks, but Linus has just pulled the fix last night.

Ah, good! Just stumbled across these when trying to cross compile the
spinlock inline patches on m68k.
To get spinlock inline patches running on m68k some more patches are
needed. I'm going to post them when I've (build) tested more architectures.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at