Re: WARNING: kmemcheck: Caught 32-bit read from uninitializedmemory (f6f6e1a4), by kmemleak's scan_block()

[Catalin Marinas]

On Tue, 2009-08-25 at 12:26 +0300, Pekka Enberg wrote:
> On Tue, 2009-08-25 at 10:21 +0100, Catalin Marinas wrote:
> > On Tue, 2009-08-25 at 12:11 +0300, Pekka Enberg wrote:
> > > On Tue, 2009-08-25 at 11:03 +0200, Vegard Nossum wrote:
> > > > I don't know so much about the kmemleak internals, but this I can say
> > > > about the kmemcheck part: According to your definition, an object is
> > > > initialized if all the bytes of an object are initialized.
> > > > 
> > > > Is it possible that because of this, if we have a partially
> > > > uninitialized object, kmemleak will not record the pointers found in
> > > > that object? If so, it might skip valid pointers, and deem an object
> > > > unreferenced. Which could make kmemleak give false-positives.
> > > > 
> > > > I think it would be better to ask kmemcheck on a per-pointer basis
> > > > (i.e. for each pointer-sized word in the object), whether it is
> > > > initialized or not.
> > > 
> > > Yeah, makes sense.
> > 
> > I think this patch should work. With a few minor (aesthetic) things
> > below and assuming that Ingo tests it (I don't have x86 hardware at hand
> > now):
> 
> Does this look OK to you?

For the kmemleak.c part:

Acked-by: Catalin Marinas <catalin.marinas@xxxxxxx>

-- 
Catalin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/