Re: [PATCH -tip] timekeeping: Fix up read_persistent_clock() breakage on sh.

From: Paul Mundt
Date: Tue Aug 25 2009 - 02:52:21 EST

On Tue, Aug 25, 2009 at 08:44:58AM +0200, Ingo Molnar wrote:
> * Paul Mundt <lethal@xxxxxxxxxxxx> wrote:
> > The recent commit "timekeeping: Increase granularity of
> > read_persistent_clock()" introduced read_persistent_clock() rework which
> > inadvertently broke the sh conversion:
> >
> > arch/sh/kernel/time.c:45: error: passing argument 1 of 'rtc_sh_get_time' from incompatible pointer type
> > distcc[13470] ERROR: compile arch/sh/kernel/time.c on sprygo/32 failed
> > make[2]: *** [arch/sh/kernel/time.o] Error 1
> >
> > This trivial fix gets it working again.
> >
> > Signed-off-by: Paul Mundt <lethal@xxxxxxxxxxxx>
> > Cc: Martin Schwidefsky <schwidefsky@xxxxxxxxxx>
> > Cc: Ingo Molnar <mingo@xxxxxxx>
> >
> > ---
> >
> > arch/sh/kernel/time.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> applied, thanks Paul!
> I'm wondering, why did my cross-build of the SH defconfig in the
> timer tree not catch this? All i get (and got) are these warnings:
> /home/mingo/tip/arch/sh/kernel/cpu/clock-cpg.c: In function 'cpg_clk_init':
> /home/mingo/tip/arch/sh/kernel/cpu/clock-cpg.c:242: warning: 'arch_init_clk_ops' is deprecated (declared at /home/mingo/tip/arch/sh/include/asm/clock.h:58)
> /home/mingo/tip/arch/sh/kernel/cpu/clock-cpg.c: In function 'arch_clk_init':
> /home/mingo/tip/arch/sh/kernel/cpu/clock-cpg.c:256: warning: 'cpg_clk_init' is deprecated (declared at /home/mingo/tip/arch/sh/kernel/cpu/clock-cpg.c:237)
> and time.o built without errors or warnings:
> CC arch/sh/kernel/time.o
That would be because read_persistent_clock() is only used conditionally
on SH, the defconfig itself does not make use of it, while the dreamcast
and sh03 defconfigs do. SH has a lot of variation across its defconfigs,
so it's pretty difficult to catch everything, this is largely what we
rely on randconfigs and allmod/yes/noconfigs for, which are all part of
the regular daily builds, in addition to the 50 or so other configs.

The defconfig itself is aimed at covering the common cases. Config
options that people will generally have enabled, and are likely to run in
to issues with. Anything else we just have to fix up incrementally and
hope that daily builds/regression testing catches the rest.

ARM suffers from the same problem in that it's really impossible to get
decent coverage in a single config.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at