[patch] arm: boolean bit testing

From: Johannes Weiner
Date: Tue Jul 21 2009 - 11:09:42 EST


Bit testing (test, testset, testclear, testchange) for bit numbers
known at compile time returns a word with the tested-for bit set.

Change it to return a true boolean value so to make it consistent with
the out-of-line path and all the other bitops implementations.

Signed-off-by: Johannes Weiner <hannes@xxxxxxxxxxx>
---
arch/arm/include/asm/bitops.h | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)

My limited ARM asm-foo says that the testop macro functions properly
already. Please double check.

diff --git a/arch/arm/include/asm/bitops.h b/arch/arm/include/asm/bitops.h
index 63a481f..338ff19 100644
--- a/arch/arm/include/asm/bitops.h
+++ b/arch/arm/include/asm/bitops.h
@@ -84,7 +84,7 @@ ____atomic_test_and_set_bit(unsigned int bit, volatile unsigned long *p)
*p = res | mask;
raw_local_irq_restore(flags);

- return res & mask;
+ return (res & mask) != 0;
}

static inline int
@@ -101,7 +101,7 @@ ____atomic_test_and_clear_bit(unsigned int bit, volatile unsigned long *p)
*p = res & ~mask;
raw_local_irq_restore(flags);

- return res & mask;
+ return (res & mask) != 0;
}

static inline int
@@ -118,7 +118,7 @@ ____atomic_test_and_change_bit(unsigned int bit, volatile unsigned long *p)
*p = res ^ mask;
raw_local_irq_restore(flags);

- return res & mask;
+ return (res & mask) != 0;
}

#include <asm-generic/bitops/non-atomic.h>
--
1.6.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/