Re: [PATCH 3/9] x86/moorestown: add moorestown platform flags

From: Alan Cox
Date: Fri Jun 26 2009 - 05:12:24 EST


> Why dont we have some clean and robust PCI config space based
> enumeration instead of this boot ID based thing?

That strikes me as a rather dumb question given that

- Embedded x86 like devices are going to regularly occur without any PCI
- You need to know the platform in order to know how to access any PCI
bus that may or may not hypothetically exist.

Take a look at how ARM and PPC address this. They do it via platform
features and descriptors for good reason.

One thing PPC does nice is to encapsulate pretty much all of it into a
struct of function pointers for each platform to keep the if conditionals
down. The ARM file layout of arch/foo/platform/bar might also be a good
idea before mrst and olpc and other stuff like this starts to make the
main x86 directory hard to read ?

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/