Re: [PATCH 3/9] x86/moorestown: add moorestown platform flags

[Ingo Molnar]

* Pan, Jacob jun <jacob.jun.pan@xxxxxxxxx> wrote:

> >From 365e3a59c34055490f137af2da281d4305535237 Mon Sep 17 00:00:00 2001
> From: Jacob Pan <jacob.jun.pan@xxxxxxxxx>
> Date: Thu, 11 Jun 2009 09:42:42 -0700
> Subject: [PATCH] x86/moorestown: add moorestown platform flags
> 
> This patch adds some new features to the x86 platform feature flags.
> 
> These new features are first introduced in Intel Moorestown platform but
> may continue to be present in the next generations.
> 
> Feature flags are initialized based on HW subarchitecture ID provided
> by the FW via boot protocol.
> 
> Signed-off-by: Jacob Pan <jacob.jun.pan@xxxxxxxxx>
> ---
>  arch/x86/Kconfig                        |   13 ++++++++++++-
>  arch/x86/include/asm/platform_feature.h |    2 ++
>  arch/x86/kernel/platform_info.c         |   12 +++++++++++-
>  3 files changed, 25 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index d1430ef..c48c291 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -1658,7 +1658,18 @@ config CMDLINE_OVERRIDE
>  
>  	  This is used to work around broken boot loaders.  This should
>  	  be set to 'N' under normal conditions.
> -
> +config MRST
> +	bool "Moorestown MID platform"
> +	default n
> +	depends on X86_32
> +	select SFI
> +	help
> +	  Moorestown is Intel's Low Power Intel Architecture (LPIA) based Moblin
> +	  Internet Device(MID) platform. Moorestown consists of two chips:
> +	  Lincroft (CPU core, graphics, and memory controller) and Langwell IOH.
> +	  Unlike standard x86 PCs, Moorestown does not have many legacy devices
> +	  nor standard legacy replacement devices/features. e.g. Moorestown does
> +	  not contain i8259, i8254, HPET, legacy BIOS, most of the io ports.
>  endmenu
>  
>  config ARCH_ENABLE_MEMORY_HOTPLUG
> diff --git a/arch/x86/include/asm/platform_feature.h b/arch/x86/include/asm/platform_feature.h
> index bcadda5..026bdc7 100644
> --- a/arch/x86/include/asm/platform_feature.h
> +++ b/arch/x86/include/asm/platform_feature.h
> @@ -45,6 +45,8 @@
>  #define X86_PLATFORM_FEATURE_ACPI		(0*32+8) /* has ACPI support */
>  #define X86_PLATFORM_FEATURE_SFI		(0*32+9) /* has SFI support */
>  #define X86_PLATFORM_FEATURE_8042		(0*32+10) /* i8042 KBC */
> +#define X86_PLATFORM_FEATURE_APBT		(0*32+11) /* APB timer */
> +#define X86_PLATFORM_FEATURE_VRTC		(0*32+12) /* virtual RTC */
>  
>  extern __u32 platform_feature[N_PLATFORM_CAPINTS];
>  extern const char *const
> diff --git a/arch/x86/kernel/platform_info.c b/arch/x86/kernel/platform_info.c
> index b39898a..3021ea9 100644
> --- a/arch/x86/kernel/platform_info.c
> +++ b/arch/x86/kernel/platform_info.c
> @@ -105,7 +105,17 @@ static int __init sysfs_platforminfo_init(void)
>  }
>  arch_initcall(sysfs_platforminfo_init);
>  
> +/* Initialize a set of default feature flags based on subarch IDs
> + * Currently, only MRST platform has non-X86 PC standard feature set.
> + */

please use the customary comment style:

  /*
   * Comment .....
   * ...... goes here:
   */

specified in Documentation/CodingStyle.

>  void platform_feature_init_default(int subarch_id)
>  {
> -	printk(KERN_INFO "Use default X86 platform feature set\n");
> +	if ((subarch_id >= 0) && (subarch_id < N_X86_SUBARCHS)) {
> +		if (subarch_id == X86_SUBARCH_MRST) {
> +			setup_mrst_default_feature();
> +			return;
> +		}
> +	} else {
> +		printk(KERN_INFO "Use default X86 platform feature set\n");
> +	}
>  }

Why dont we have some clean and robust PCI config space based 
enumeration instead of this boot ID based thing?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/