Re: >= 2.6.30 broken alpha smp build

From: Tejun Heo
Date: Thu Jun 25 2009 - 20:44:14 EST


Andrew Morton wrote:
> This is the
>
> #define PER_CPU_ATTRIBUTES __used
>
> in arch/alpha/include/asm/percpu.h, added by
>
> commit 9267b4b3880d00dc2dab90f1d817c856939114f7
> Author: Ivan Kokshaysky <ink@xxxxxxxxxxxxxxxxxxxx>
> AuthorDate: Sat Jun 21 03:25:39 2008 +0400
> Commit: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> CommitDate: Fri Jun 20 16:46:10 2008 -0700
>
> alpha: fix module load failures on smp (bug #10926)
>
> There's no indication in the changelog why this was added and afacit no
> other architectures do it. So I'm at a loss to help here.

The __used attribute is dropped by a patch in percpu patchset as it
caused build warning on my test builds and wasn't even effective
as-was (overriden by later NULL definition). Ivan, any ideas why it's
there?

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/