Re: [Patch 1/2] kbuild: two trivial fixes for check headers

From: Sam Ravnborg
Date: Thu Jun 04 2009 - 05:13:20 EST


On Thu, Jun 04, 2009 at 04:01:52AM -0400, Amerigo Wang wrote:
>
> Remove a useless 'extern' in an exported header.
> Fix a comment headers_check.pl.

These two patches has nothing in commom.

>
> Signed-off-by: WANG Cong <amwang@xxxxxxxxxx>
> Cc: Sam Ravnborg <sam@xxxxxxxxxxxx>
>
> ------
> diff --git a/include/mtd/jffs2-user.h b/include/mtd/jffs2-user.h
> index fa94b0e..10dc7ef 100644
> --- a/include/mtd/jffs2-user.h
> +++ b/include/mtd/jffs2-user.h
> @@ -18,7 +18,7 @@
> #undef je32_to_cpu
> #undef jemode_to_cpu
>
> -extern int target_endian;
> +int target_endian;

You now declare a global variable named target_endian each time you include this file - which is wrong.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/