Re: [PATCH v3 1/3] Make section names compatible with -ffunction-sections -fdata-sections

From: Rusty Russell
Date: Sun Apr 26 2009 - 09:09:35 EST


On Sat, 25 Apr 2009 02:53:58 am Sam Ravnborg wrote:
> > ---
> > Documentation/mutex-design.txt | 4 +-
> > arch/alpha/kernel/head.S | 2 +-
> ...
> > include/linux/linkage.h | 4 +-
> > include/linux/spinlock.h | 2 +-
> > kernel/module.c | 2 +-
> > scripts/mod/modpost.c | 12 ++++----
> > scripts/recordmcount.pl | 6 ++--
> > 141 files changed, 356 insertions(+), 348 deletions(-)
>
> This patch touches far too many files.
> We should try to work out a method so we are in better control
> of the section names, so renaming in the end is a simple patch
> touching only a few files.

Completely disagree. You'll end up touching all these files, and leaving
us with now-unnecessary a level of indirection. Also, you'll have performed
a giant pile of make-work, and bothered all the maintainers.

Just get Linus to apply the damn patch already; it's been sitting around too
long. Then do any cleanups which are actual cleanups.

Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/