Re: [PATCH 2/2] regulator: add userspace-consumer driver

[Mike Rapoport]

Mark Brown wrote:
> On Sun, Apr 26, 2009 at 02:47:04PM +0300, Mike Rapoport wrote:
>> Mark Brown wrote:
> 
>>> Why are you using a regulator_consumer_supply here?  All that's being
>>> used here is the name and I can't see why you'd want the device.
> 
>> For upwards compatibility :)
>> Well, seriously, I think using 'struct regulator_consumer_supply *supplies'
>> rather than 'char *supplies' makes the platform code that registers the
>> userspace-consumer device clearer.
> 
> On the other hand it merges the consumer and machine APIs, which we
> really want to keep separate, and I can't see having the struct device
> in there doing anything except confuse people.  If you're going to pick
> an existing structure to use I'd be more inclined to use the bulk
> consumer structure (which the driver needs to allocate anyway).

Ok, I'll use bulk consumer and then apparently I can avoid it's allocation...


-- 
Sincerely yours,
Mike.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/