Re: [PATCH] regulator core: fix double-free in regulator_register()error path

From: Paul Walmsley
Date: Sun Apr 26 2009 - 00:53:52 EST


On Sat, 25 Apr 2009, Paul Walmsley wrote:

> During regulator registration, any error after device_register() will
> cause a double-free on the struct regulator_dev 'rdev'. The bug is in
> drivers/regulator/core.c:regulator_register():
>
> ...
>
> device_unregister() calls regulator_dev_release() which frees rdev. The
> subsequent kfree corrupts memory and causes some OMAP3 systems to oops on
> boot in regulator_get().

For the 3430SDP users out there, this patch also fixes the boot hang after
"regulator_init_complete: incomplete constraints, leaving VAUX3 on"
on that device.

- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/