Re: [PATCH 2/3] mg_disk: fix dependency on libata

[Jeff Garzik]

Tejun Heo wrote:
> Jeff Garzik wrote:
> > Actually...  NVMHCI[1] uses the same style of id string extraction, even
> > though its command set is wholly new and unrelated to ATA.  I copied
> > into drivers/block/nvmhci.c[2] id_string, id_c_string and another
> > useful, generic routine: ata_wait_register.
> >
> > So, once nvmhci goes upstream, that will be a third copy...  nvmhci
> > still has rough edges, but it's mainly waiting on hardware "it works"
> > verification at this point.
>
> For two copies, copying seems to be the right way to go.  For many
> more copies, making a library function is.  Three is a difficult
> number.  Maybe just make these inline functions for now?

<shrug>  I'm just adding some data, I don't have a good suggestion :)

The functions do not change very often, so three copies is not 
necessarily the end of the world.

	Jeff



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/