Re: [patch 14/18] x86, ds: use single debug store cpu configuration

[Ingo Molnar]

* markus.t.metzger@xxxxxxxxx <markus.t.metzger@xxxxxxxxx> wrote:

> Use a single configuration for all cpus.
> 

> @@ -1291,11 +1290,15 @@ ds_configure(const struct ds_configurati
>  	printk("bts/pebs record: %u/%u bytes\n",
>  	       ds_cfg.sizeof_rec[ds_bts], ds_cfg.sizeof_rec[ds_pebs]);
>  
> -	WARN_ON_ONCE(MAX_SIZEOF_DS < (12 * ds_cfg.sizeof_ptr_field));
> +	WARN_ON(MAX_SIZEOF_DS < (12 * ds_cfg.sizeof_ptr_field));

Why this change?

Firstly, it was not declared in the changelog which is a no-no. 

Secondly, this is a bad change: we are more than content to have a 
single such warning bootup - not dozens of it (on some large 
system).

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/