Re: [PATCH 06/43] FS-Cache: Recruit a couple of page flags forcache management [ver #46]

[Trond Myklebust]

On Thu, 2009-04-02 at 18:40 +0100, David Howells wrote:
> Nick Piggin <nickpiggin@xxxxxxxxxxxx> wrote:
> 
> > Well in theory I still think it would be cleanest to modify buffer to
> > play more nicely with it. But maybe that ends up being harder to
> > distinguish the 3 cases of attached metadata on the page. I don't know,
> > you haven't posted any isofs code so either way it is inappropriate to
> > use up this extra page flag here.
> > 
> > Is isofs cache worth a page flag?
> 
> Well, isofs was something I wanted at the time.
> 
> Besides, as I said NFS uses PG_private for its own purposes, and entangling
> the two wasn't the most fun I've had.  Trond didn't like it either.

We use it for exactly the same purpose as everyone else: to signal that
we need a callback to ->releasepage() if the VM wants to truncate the
page.

Trond

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/