Re: [PATCH 06/43] FS-Cache: Recruit a couple of page flags for cache management [ver #46]

[Nick Piggin]

On Friday 03 April 2009 04:40:57 David Howells wrote:
> Nick Piggin <nickpiggin@xxxxxxxxxxxx> wrote:
> 
> > Well in theory I still think it would be cleanest to modify buffer to
> > play more nicely with it. But maybe that ends up being harder to
> > distinguish the 3 cases of attached metadata on the page. I don't know,
> > you haven't posted any isofs code so either way it is inappropriate to
> > use up this extra page flag here.
> > 
> > Is isofs cache worth a page flag?
> 
> Well, isofs was something I wanted at the time.

It can't be done with FUSE?


> Besides, as I said NFS uses PG_private for its own purposes, and entangling
> the two wasn't the most fun I've had.  Trond didn't like it either.

IMO that is quite OK to make them go through the pain of that if it
avoids resulting in a new page flag that is probably unusable to most
other filesystems.

But... I guess I won't get hung up on it. If you avoid at least one of
these flags it would be a good start.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/