Re: 2.6.29-git: cannot mount ext4/loop

[Thiemo Nagel]

Theodore Tso wrote:
> On Thu, Apr 02, 2009 at 03:30:26PM +0200, Thiemo Nagel wrote:
> > When I added the block range checks, initially I was assuming that
> > when EXTENTS_FL is not set, the inode->i_data *always* contains
> > references to further blocks.  Ted showed me wrong and added the condition
> >
> > 	ISREG() || ISDIR() || ( ISLNK() && !is_fast_symlink() )
> >
> > before that assumption can be made.  But maybe we need some further
> > restraints?
>
> It's a endian-problem; we're missing le32_to_cpu() in that patch.
> Sparc is big-endian. 

Sorry for that.

Thiemo

---
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 98e289a..ec3555d 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -377,11 +377,11 @@ static int __ext4_check_blockref(const char 
*function, struct inode *inode,
        unsigned int maxblocks = 
ext4_blocks_count(EXT4_SB(inode->i_sb)->s_es);
        unsigned int *bref = p;
        while (bref < p+max) {
-               if (unlikely(*bref >= maxblocks)) {
+               if (unlikely(le32_to_cpu(*bref) >= maxblocks)) {
                        ext4_error(inode->i_sb, function,
                                   "block reference %u >= max (%u) "
                                   "in inode #%lu, offset=%d",
-                                  *bref, maxblocks,
+                                  le32_to_cpu(*bref), maxblocks,
                                   inode->i_ino, (int)(bref-p));
                        return -EIO;
                }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/