Re: [PATCH 1/2 V3] kaweth: Fix locking to be SMP-safe

[Larry Finger]

Herbert Xu wrote:
> Larry Finger <Larry.Finger@xxxxxxxxxxxx> wrote:
>> @@ -796,7 +795,7 @@ static int kaweth_start_xmit(struct sk_b
>>
>>        int res;
>>
>> -       spin_lock(&kaweth->device_lock);
>> +       spin_lock_irq(&kaweth->device_lock);
> 
> Should be irqsave unless you don't expect to be called via netpoll.

The .ndo_poll_controller callback is left at NULL in this driver. I believe the
patch to be OK.

Larry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/