Re: [PATCH 1/2 V3] kaweth: Fix locking to be SMP-safe

[Herbert Xu]

Larry Finger <Larry.Finger@xxxxxxxxxxxx> wrote:
>
> @@ -796,7 +795,7 @@ static int kaweth_start_xmit(struct sk_b
> 
>        int res;
> 
> -       spin_lock(&kaweth->device_lock);
> +       spin_lock_irq(&kaweth->device_lock);

Should be irqsave unless you don't expect to be called via netpoll.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/