Re: add_to_swap_cache with GFP_ATOMIC ?

From: Hugh Dickins
Date: Wed Apr 01 2009 - 07:47:37 EST


On Wed, 1 Apr 2009, KOSAKI Motohiro wrote:
>
> IOW, GFP_ATOMIC on add_to_swap() was introduced accidentally. the reason
> was old add_to_page_cache() didn't have gfp_mask parameter and we didn't
> have the reason of changing add_to_swap() behavior.
> I think it don't have deeply reason and changing GFP_NOIO
> don't cause regression.

You may well be right: we'll see if you send in a patch to change it.
But I won't be sending in that patch myself, that's all :)

Hugh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/