Re: [osd-dev] [PATCH 6/8] exofs: super_operations and file_system_type

From: Boaz Harrosh
Date: Wed Apr 01 2009 - 04:07:53 EST


On 03/31/2009 09:52 PM, Benny Halevy wrote:
> On Mar. 31, 2009, 11:04 +0300, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>> ~0 is signed 0xffffffff.
>>
>> When assigning to a u64 it gets signed extended to signed
>> 0xffffffffffffffff and then converted to unsigned 0xffffffffffffffff.
>
> Right (I think, I'm not sure in what order)
>
>> I think. Just as with plain old "-1". Perhaps using plain old "-1"
>> would be clearer here.
>
> or maybe ~0ULL or ~(uint64_t)0 to be extremely anal about it.
>
> Benny
>

There is only one right way => ULLONG_MAX. Takes care of the human factor
too. (BTW that one is defined (~0ULL))

Thanks
Boaz

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/