Re: [PATCH] x86: introduce bootmem_state

[Ingo Molnar]

* Yinghai Lu <yinghai@xxxxxxxxxx> wrote:

> Impact: cleanup
> 
> extend after_bootmem and after_init_bootmem to bootmem_state 
> and will have BEFORE_BOOTMEM, DURING_BOOTMEM, AFTER_BOOTMEM

Ok, that indeed makes all these bootstrap initialization details 
cleaner and more transparent.

> Signed-off-by: Yinghai Lu <yinghai@xxxxxxxxxx>
> 
> ---
>  arch/x86/kernel/setup.c |    1 +
>  arch/x86/mm/init.c      |   13 +++++++------
>  arch/x86/mm/init_32.c   |   28 ++++++++++++++++++++--------
>  arch/x86/mm/init_64.c   |   33 +++++++++++++++++++--------------
>  include/linux/mm.h      |    8 ++++++++
>  5 files changed, 55 insertions(+), 28 deletions(-)

Note: "git grep after_bootmem" will show you another affected 
architecture as well.

> +++ linux-2.6/include/linux/mm.h
> @@ -1067,6 +1067,14 @@ extern void __init mmap_init(void);
>  extern void show_mem(void);
>  extern void si_meminfo(struct sysinfo * val);
>  extern void si_meminfo_node(struct sysinfo *val, int nid);
> +
> +enum bootmem_state_t {
> +	BEFORE_BOOTMEM = 0,

(nit: =0 is not required. )

> +	DURING_BOOTMEM,
> +	AFTER_BOOTMEM
> +};
> +extern enum bootmem_state_t bootmem_state;

(nit: we put newlines after enum definitions)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/