Re: + cgroup-memcg-show-correct-file-mode.patch added to -mm tree

From: Ingo Molnar
Date: Tue Mar 03 2009 - 02:58:57 EST



* akpm@xxxxxxxxxxxxxxxxxxxx <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> .name = "usage_in_bytes",
> .private = MEMFILE_PRIVATE(_MEM, RES_USAGE),
> .read_u64 = mem_cgroup_read,
> + .mode = 0444

Uhm, we've got symbols for permission bits for a reason.
(S_IRUGO in this case)

> + .mode = 0444

Ditto.

> + .mode = 0200

Ditto. (S_IWUSR)

> + .mode = 0444

Ditto.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/