Re: [PATCH 14/15] bitops: Change the bitmap index from int to unsigned long [frv]

[David Howells]

H. Peter Anvin <hpa@xxxxxxxxx> wrote:

> What makes you say that, in particular?

I prefer it.  Actually, I'd prefer it all to be on one line, but some people
get picky about the 80 char limit.

Besides, that "static inline" is merely a qualifier to the declaration of the
function.  The return type, name and args are part of the declaration of the
function and belong together more.

> A casual grep finds no less than 3524 instances of "static inline <type>" --
> presumably with a function name following -- and only 447 instances of
> "static inline" without a type in the kernel.

But how does it break down between "static inline type\nfunction_name" and
"static inline\ntype function_name"?  That's more to the point.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/