Re: [PATCH 14/15] bitops: Change the bitmap index from int to unsignedlong [frv]

[H. Peter Anvin]

David Howells wrote:
> > -static inline int __constant_test_bit(int nr, const volatile void * addr)
> > +static inline int
> > +__constant_test_bit(unsigned long nr, const volatile void *addr)
>
> Please move the return type onto the next line also.  Other than that:
>
> Acked-by: David Howells <dhowells@xxxxxxxxxx>

What makes you say that, in particular?   A casual grep finds no less 
than 3524 instances of "static inline <type>" -- presumably with a 
function name following -- and only 447 instances of "static inline" 
without a type in the kernel.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/