Re: [patch 3/7] epoll keyed wakeups - introduce key-aware wakeupmacros

From: Alan Cox
Date: Sat Jan 31 2009 - 04:25:59 EST

> One minor worry i have: these wakeup calls are _very_ common in the
> kernel, and this patch adds an extra parameter to it that is unused (NULL)
> in 99% of the cases.

And in most of the cases it is used is constant for the waitqueue anyway
or appears to be (eg the tty patch). I don't think we should be stacking
extra parameters on all those zillions of calls made all over the kernel
and for no purpose - so the existing wakeup functions should stay as is
for performance as well as for size (which due to cache pressure is

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at