Re: [PATCH] w35und: fix registration with wlan stack

[Johannes Berg]

On Fri, 2009-01-30 at 11:13 +0200, Pekka Enberg wrote:


> >  	dev->extra_tx_headroom = 12;	/* FIXME */
> > -	dev->flags = 0;
> > +	dev->flags = IEEE80211_HW_SIGNAL_UNSPEC;
> > +	dev->wiphy->interface_modes = BIT(NL80211_IFTYPE_STATION);
> 
> The wiphy->interface_modes thing is probably fall-out from commit
> 8dffff216fcac4f79078478085e86d68db64922e ("mac80211: only create default
> STA interface if supported"). I'm cc'ing Johannes.

Yes. That looks reasonable, though it means you'll only support STA, not
ad-hoc.

> >  
> >  	dev->channel_change_time = 1000;
> > +	dev->max_signal = 100;
> 
> And the IEEE80211_HW_SIGNAL_UNSPEC and ->max_signal from commit
> 566bfe5a8bcde13188a356f77666f8115813cf31 ("mac80211: use hardware flags
> for signal/noise units"). Lets cc Bruno.

Seems reasonable, though does it would be good to see if it can do DBM,
which we very very much prefer.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part