Re: [PATCH RFT 7/7] firewire: sbp2: add workarounds for 2nd and 3rdgeneration iPods

From: Stefan Richter
Date: Wed Jan 28 2009 - 18:12:26 EST


Jarod Wilson wrote:
> On Saturday 24 January 2009 13:46:44 Stefan Richter wrote:
>> - Do 2nd and 3rd gen. iPods actually have a model_id == 0, or do they
>> have in fact no model_id at all?
>
> So far as I can decipher (using Kristian's csr-dump utility), they really
> do have model_id == 0.

If model_id weren't there, the older ieee1394/sbp2 driver would log
model_id 0 (and match against quirks list entries with ID 0), while
firewire-sbp2 logs model_id 0xff000000 (which is an impossible value and
thus indicates to those who want to write a new quirks list entry that
there is actually no model_id...). I will soon push the patch which
makes sbp2 behave like firewire-sbp2 in this regard, to eliminate a
potential source of conflicting user reports.
--
Stefan Richter
-=====-==--= ---= ===-=
http://arcgraph.de/sr/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/